Agents - remove the dependency on IAgentSessionsService#315992
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to remove the Agents window “Changes” experience’s dependency on IAgentSessionsService, relying instead on ISessionsManagementService’s active session/workspace model for repository and git state.
Changes:
- Removed
IAgentSessionsServiceusage fromChangesViewModel, sourcing repository info and git state fromsessionManagementService.activeSession.workspace. - Updated repository diff retrieval to operate on
URIrather than a file-path string. - Adjusted Copilot chat session metadata → workspace repository extraction by dropping the
workingDirectoryPathfallback.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts | Updates how repository/worktree URIs are derived from agent session metadata (notably removing workingDirectoryPath handling). |
| src/vs/sessions/contrib/changes/browser/changesViewModel.ts | Removes IAgentSessionsService dependency and switches repository detection/diff logic to use the sessions management workspace model and URI inputs. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 3
alexr00
previously approved these changes
May 12, 2026
alexr00
approved these changes
May 12, 2026
sandy081
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.