Skip to content

Update manage models heading detection#316028

Merged
pwang347 merged 6 commits into
mainfrom
pawang/ubbModelManagement
May 13, 2026
Merged

Update manage models heading detection#316028
pwang347 merged 6 commits into
mainfrom
pawang/ubbModelManagement

Conversation

@pwang347
Copy link
Copy Markdown
Member

Partially fixes #315789

Copilot AI review requested due to automatic review settings May 12, 2026 15:34
@pwang347 pwang347 marked this pull request as ready for review May 12, 2026 15:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the “Manage Models” table pricing/cost column header sizing/labeling logic to be driven by the user’s billing mode (usage-based billing) rather than by scanning the currently materialized table entries. This aligns the column heading with the intended semantics (credits-per-token costs vs generic pricing) and avoids heading changes based on expand/collapse state.

Changes:

  • Derive an isUBB flag from chatEntitlementService.quotas.usageBasedBilling.
  • Use isUBB to choose the pricing column label (“Cost (Credits per 1M Tokens)” vs “Pricing”).
  • Use isUBB to choose the pricing column width/weight.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/browser/chatManagement/chatModelsWidget.ts Switch pricing column heading/width logic to usage-based billing detection via entitlement quotas.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

dmitrivMS
dmitrivMS previously approved these changes May 12, 2026
@pwang347 pwang347 enabled auto-merge (squash) May 12, 2026 20:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

Screenshot Changes

Base: 420d10c3 Current: a1858868

Changed (2)

agentSessionsViewer/CloudProvider/Dark
Before After
before after
agentSessionsViewer/CloudProvider/Light
Before After
before after

@pwang347 pwang347 merged commit 6a0d8bc into main May 13, 2026
25 checks passed
@pwang347 pwang347 deleted the pawang/ubbModelManagement branch May 13, 2026 02:31
@vs-code-engineering vs-code-engineering Bot added this to the 1.121.0 milestone May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

manage models menu: pricing is confusing

3 participants