Skip to content

Revert "run_in_terminal: promote sync command to background after idle output"#316165

Merged
meganrogge merged 1 commit into
mainfrom
revert-315885-merogge/terminal-idle-silence-promotion
May 13, 2026
Merged

Revert "run_in_terminal: promote sync command to background after idle output"#316165
meganrogge merged 1 commit into
mainfrom
revert-315885-merogge/terminal-idle-silence-promotion

Conversation

@meganrogge
Copy link
Copy Markdown
Collaborator

@meganrogge meganrogge commented May 13, 2026

Reverts #315885
Fixes https://github.com/microsoft/vscode-copilot-evaluation/issues/3870

Reverting for now as this caused some eval regressions on eval assessment flow PR - only for opus 4.7, going to bring back in a PR #316166 and run eval flow on it now that it's working again before merging.

Copilot AI review requested due to automatic review settings May 13, 2026 01:29
@meganrogge meganrogge self-assigned this May 13, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@meganrogge meganrogge added this to the 1.121.0 milestone May 13, 2026
@meganrogge meganrogge enabled auto-merge (squash) May 13, 2026 01:29
@github-actions
Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 420d10c3 Current: 561f6e22

Changed (2)

agentSessionsViewer/CloudProvider/Dark
Before After
before after
agentSessionsViewer/CloudProvider/Light
Before After
before after

@meganrogge meganrogge merged commit 57fa97f into main May 13, 2026
25 checks passed
@meganrogge meganrogge deleted the revert-315885-merogge/terminal-idle-silence-promotion branch May 13, 2026 02:31
meganrogge pushed a commit that referenced this pull request May 13, 2026
The revert in main (#316165) removed the idle-silence feature. This merge
keeps all idle-silence changes from the branch: race candidate, config
setting, steering text refactor, and tests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants