Skip to content

Remove model picker category#316280

Merged
lramos15 merged 2 commits into
mainfrom
lramos15/moaning-starfish
May 13, 2026
Merged

Remove model picker category#316280
lramos15 merged 2 commits into
mainfrom
lramos15/moaning-starfish

Conversation

@lramos15
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 13, 2026 17:50
@lramos15 lramos15 enabled auto-merge (squash) May 13, 2026 17:50
@lramos15 lramos15 self-assigned this May 13, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the “model picker category” concept from VS Code’s chat/language model plumbing, including the proposed chatProvider API surface and the internal metadata used for model selection and sorting. This simplifies model ordering (now name-based) and removes now-obsolete test expectations.

Changes:

  • Removed LanguageModelChatInformation.category from the proposed vscode.proposed.chatProvider API.
  • Removed internal modelPickerCategory handling (including default category constant) and switched sorting to name.localeCompare(...).
  • Updated unit tests and fixtures to no longer provide/expect category fields.
Show a summary per file
File Description
src/vscode-dts/vscode.proposed.chatProvider.d.ts Removes proposed API category field (breaking change; version bump needed).
src/vs/workbench/contrib/chat/common/languageModels.ts Drops modelPickerCategory from internal model metadata interface.
src/vs/workbench/contrib/chat/browser/defaultModelContribution.ts Simplifies model sorting to name-only.
src/vs/workbench/api/common/extHostLanguageModels.ts Removes mapping from proposed category into internal metadata.
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostLanguageModelProvider.ts Stops emitting modelPickerCategory in provided model metadata.
src/vs/workbench/contrib/chat/common/widget/input/modelPickerWidget.ts Removes default category constant; file is now empty.
src/vs/workbench/contrib/chat/test/common/tools/builtinTools/runSubagentTool.test.ts Updates test fixtures to drop modelPickerCategory.
src/vs/workbench/contrib/chat/test/common/languageModels.test.ts Removes default category constant usage and category-related metadata fields.
src/vs/workbench/contrib/chat/test/browser/widget/input/chatModelSelectionLogic.test.ts Updates test model factory to omit modelPickerCategory.
src/vs/workbench/contrib/chat/test/browser/widget/input/chatModelPicker.test.ts Updates test model factory to omit modelPickerCategory.
src/vs/workbench/contrib/chat/test/browser/promptSyntax/languageProviders/promptValidator.test.ts Updates inline model metadata fixtures to omit modelPickerCategory.
src/vs/workbench/contrib/chat/test/browser/promptSyntax/languageProviders/promptHovers.test.ts Updates inline model metadata fixtures to omit modelPickerCategory.
src/vs/workbench/contrib/chat/test/browser/promptSyntax/languageProviders/promptHeaderAutocompletion.test.ts Updates inline model metadata fixtures to omit modelPickerCategory.
src/vs/workbench/contrib/chat/test/browser/chatManagement/chatModelsViewModel.test.ts Removes category fields from model fixtures.
src/vs/sessions/contrib/providers/agentHost/test/browser/agentHostModelPicker.test.ts Updates agent host model fixture to omit modelPickerCategory.

Copilot's findings

Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/common/widget/input/modelPickerWidget.ts:7

  • This file no longer exports anything and appears to be unused (no remaining references to modelPickerWidget or DEFAULT_MODEL_PICKER_CATEGORY). Consider deleting the file entirely to avoid carrying an empty/dead module forward.
/*---------------------------------------------------------------------------------------------
 *  Copyright (c) Microsoft Corporation. All rights reserved.
 *  Licensed under the MIT License. See License.txt in the project root for license information.
 *--------------------------------------------------------------------------------------------*/



  • Files reviewed: 14/15 changed files
  • Comments generated: 0

@lramos15 lramos15 merged commit d6576bc into main May 13, 2026
26 checks passed
@lramos15 lramos15 deleted the lramos15/moaning-starfish branch May 13, 2026 18:17
@vs-code-engineering vs-code-engineering Bot added this to the 1.121.0 milestone May 13, 2026
NikolaRHristov pushed a commit to CodeEditorLand/Editor that referenced this pull request May 13, 2026
* Remove model picker category

* fix compile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants