Remove model picker category#316280
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the “model picker category” concept from VS Code’s chat/language model plumbing, including the proposed chatProvider API surface and the internal metadata used for model selection and sorting. This simplifies model ordering (now name-based) and removes now-obsolete test expectations.
Changes:
- Removed
LanguageModelChatInformation.categoryfrom the proposedvscode.proposed.chatProviderAPI. - Removed internal
modelPickerCategoryhandling (including default category constant) and switched sorting toname.localeCompare(...). - Updated unit tests and fixtures to no longer provide/expect category fields.
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.chatProvider.d.ts | Removes proposed API category field (breaking change; version bump needed). |
| src/vs/workbench/contrib/chat/common/languageModels.ts | Drops modelPickerCategory from internal model metadata interface. |
| src/vs/workbench/contrib/chat/browser/defaultModelContribution.ts | Simplifies model sorting to name-only. |
| src/vs/workbench/api/common/extHostLanguageModels.ts | Removes mapping from proposed category into internal metadata. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostLanguageModelProvider.ts | Stops emitting modelPickerCategory in provided model metadata. |
| src/vs/workbench/contrib/chat/common/widget/input/modelPickerWidget.ts | Removes default category constant; file is now empty. |
| src/vs/workbench/contrib/chat/test/common/tools/builtinTools/runSubagentTool.test.ts | Updates test fixtures to drop modelPickerCategory. |
| src/vs/workbench/contrib/chat/test/common/languageModels.test.ts | Removes default category constant usage and category-related metadata fields. |
| src/vs/workbench/contrib/chat/test/browser/widget/input/chatModelSelectionLogic.test.ts | Updates test model factory to omit modelPickerCategory. |
| src/vs/workbench/contrib/chat/test/browser/widget/input/chatModelPicker.test.ts | Updates test model factory to omit modelPickerCategory. |
| src/vs/workbench/contrib/chat/test/browser/promptSyntax/languageProviders/promptValidator.test.ts | Updates inline model metadata fixtures to omit modelPickerCategory. |
| src/vs/workbench/contrib/chat/test/browser/promptSyntax/languageProviders/promptHovers.test.ts | Updates inline model metadata fixtures to omit modelPickerCategory. |
| src/vs/workbench/contrib/chat/test/browser/promptSyntax/languageProviders/promptHeaderAutocompletion.test.ts | Updates inline model metadata fixtures to omit modelPickerCategory. |
| src/vs/workbench/contrib/chat/test/browser/chatManagement/chatModelsViewModel.test.ts | Removes category fields from model fixtures. |
| src/vs/sessions/contrib/providers/agentHost/test/browser/agentHostModelPicker.test.ts | Updates agent host model fixture to omit modelPickerCategory. |
Copilot's findings
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/chat/common/widget/input/modelPickerWidget.ts:7
- This file no longer exports anything and appears to be unused (no remaining references to
modelPickerWidgetorDEFAULT_MODEL_PICKER_CATEGORY). Consider deleting the file entirely to avoid carrying an empty/dead module forward.
/*---------------------------------------------------------------------------------------------
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
- Files reviewed: 14/15 changed files
- Comments generated: 0
pwang347
approved these changes
May 13, 2026
NikolaRHristov
pushed a commit
to CodeEditorLand/Editor
that referenced
this pull request
May 13, 2026
* Remove model picker category * fix compile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.