Fix wrappingIndent in accessibility mode#316384
Open
1821746019 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes editor.wrappingIndent being ignored when accessibility support is enabled by removing the accessibility-mode override and adding a regression test.
Changes:
- Removed forced
WrappingIndent.Nonebehavior in accessibility mode. - Added a test that verifies
wrappingIndent: 'indent'is preserved withAccessibilitySupport.Enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/editor/common/config/editorOptions.ts |
Removes the accessibility-specific wrapping indent override. |
src/vs/editor/test/browser/config/editorConfiguration.test.ts |
Adds regression coverage for wrapping indent in accessibility mode. |
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #298865
This change removes the accessibility-specific override that forced
editor.wrappingIndenttonone, so the editor now respects the user-configured wrapping indent even when accessibility support is enabled.It also adds a regression test covering
AccessibilitySupport.Enabledtogether withwrappingIndent: 'indent'.Validation:
VS Code - Buildcould not run in this environment becausedeemonis missing.npm run compile-check-ts-nativecould not run in this environment becausetsgois missing.