build: retry TSA upload task#316479
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Yoyokrazy
approved these changes
May 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves reliability of the Windows SDL scan pipeline by adding automatic retries to the existing TSA upload step, reducing noise from transient TSA service/network failures while keeping the pipeline’s current “continue on error” behavior.
Changes:
- Add
retryCountOnTaskFailure: 3to theTSAUpload@2task in the Win32 SDL scan pipeline.
Show a summary per file
| File | Description |
|---|---|
| build/azure-pipelines/win32/sdl-scan-win32.yml | Adds task-level retry to the TSA upload step to better tolerate transient failures. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
dmitrivMS
approved these changes
May 14, 2026
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
retryCountOnTaskFailure: 3to the existingTSAUpload@2task in the Windows SDL scan pipeline.The TSA upload step already exists and is marked
continueOnError: true; this change gives transient TSA upload failures a few automatic retries before continuing, without adding a new task block or changing the broader 1ES SDL configuration.