Make URLs GHE aware#316630
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes Copilot-related “manage settings/budget” links GitHub Enterprise-aware by routing URL construction through IDefaultAccountService, and removes the now-inappropriate fully-qualified GitHub.com URLs from product configuration.
Changes:
- Add
resolveGitHubUrl(path)toIDefaultAccountProvider/IDefaultAccountServiceand implement enterprise-aware resolution in the workbench default account provider. - Update chat/setup/onboarding UI surfaces to use
defaultAccountService.resolveGitHubUrl(...)instead ofproduct.defaultChatAgent.manageSettingsUrl/manageOverageUrl. - Remove
manageSettingsUrlandmanageOverageUrlfromIDefaultChatAgentandproduct.json.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts | Updates test service fixture to include resolveGitHubUrl. |
| src/vs/workbench/services/policies/test/browser/multiplexPolicyService.test.ts | Updates policy test provider stub to implement resolveGitHubUrl. |
| src/vs/workbench/services/policies/test/browser/accountPolicyService.test.ts | Updates policy test provider stub to implement resolveGitHubUrl. |
| src/vs/workbench/services/accounts/browser/defaultAccount.ts | Implements enterprise-aware resolveGitHubUrl on provider/service. |
| src/vs/workbench/contrib/welcomeOnboarding/browser/onboardingVariationA.ts | Switches Copilot settings link to enterprise-aware URL resolution. |
| src/vs/workbench/contrib/welcomeGettingStarted/common/gettingStartedContent.ts | Refactors Copilot settings message to accept a settings URL at call time. |
| src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts | Injects IDefaultAccountService and uses it for “manage settings” URL. |
| src/vs/workbench/contrib/chat/browser/chatStatus/chatStatusDashboard.ts | Uses enterprise-aware URL resolution for settings/budget links. |
| src/vs/workbench/contrib/chat/browser/chatSetup/chatSetupRunner.ts | Uses enterprise-aware URL resolution for setup footer settings link. |
| src/vs/workbench/contrib/chat/browser/chatSetup/chatSetupContributions.ts | Uses enterprise-aware URL resolution for “Manage Budget” command. |
| src/vs/workbench/contrib/chat/browser/actions/chatActions.ts | Uses enterprise-aware URL resolution for “Manage Copilot Settings” action. |
| src/vs/sessions/test/web.test.ts | Updates sessions test default account mock to include resolveGitHubUrl. |
| src/vs/sessions/browser/sessionsSetUpService.ts | Uses enterprise-aware URL resolution for setup footer settings link. |
| src/vs/platform/defaultAccount/common/defaultAccount.ts | Extends default account provider/service interfaces with resolveGitHubUrl (with JSDoc). |
| src/vs/editor/standalone/browser/standaloneServices.ts | Adds resolveGitHubUrl to standalone default account service implementation. |
| src/vs/editor/contrib/inlineCompletions/test/browser/utils.ts | Updates inline completions test service stub to include resolveGitHubUrl. |
| src/vs/base/common/product.ts | Removes manageSettingsUrl/manageOverageUrl from IDefaultChatAgent. |
| product.json | Removes defaultChatAgent.manageSettingsUrl/manageOverageUrl values. |
Copilot's findings
- Files reviewed: 18/18 changed files
- Comments generated: 2
bryanchen-d
approved these changes
May 15, 2026
|
`` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up needed for Copilot extension