Skip to content

add /models to agents window new input#317060

Merged
justschen merged 1 commit into
mainfrom
justin/crabominable
May 18, 2026
Merged

add /models to agents window new input#317060
justschen merged 1 commit into
mainfrom
justin/crabominable

Conversation

@justschen
Copy link
Copy Markdown
Collaborator

/models now works in the new agents window input

Copilot AI review requested due to automatic review settings May 18, 2026 16:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for /models in the Agents window new chat input by introducing a per-input model picker opener service and wiring existing model picker widgets into it.

Changes:

  • Adds INewChatModelPickerService and registers /models as an immediate slash command.
  • Scopes model picker openers through NewChatInputWidget child instantiation.
  • Updates Copilot/agent-host model pickers, docs, and tests to use the scoped service.
Show a summary per file
File Description
src/vs/sessions/contrib/chat/browser/newChatModelPicker.ts Adds the scoped model picker opener service.
src/vs/sessions/contrib/chat/browser/newChatInput.ts Creates a per-input scoped service and uses it for slash commands/config toolbar.
src/vs/sessions/contrib/chat/browser/slashCommands.ts Adds the /models slash command.
src/vs/sessions/contrib/chat/test/browser/newChatModelPicker.test.ts Tests scoped opener isolation.
src/vs/sessions/contrib/providers/copilotChatSessions/browser/copilotChatSessionsActions.ts Wires local Copilot model picker into the scoped service.
src/vs/sessions/contrib/providers/copilotChatSessions/browser/modelPicker.ts Wires cloud Copilot model picker into the scoped service.
src/vs/sessions/contrib/providers/copilotChatSessions/test/browser/modelPickerDelegate.test.ts Stubs the new service for existing picker tests.
src/vs/sessions/contrib/providers/copilotChatSessions/COPILOT_CHAT_SESSIONS_PROVIDER.md Documents scoped instantiation requirements for model pickers.
src/vs/sessions/contrib/providers/agentHost/browser/agentHostModelPicker.ts Wires desktop agent-host model picker into the scoped service.
src/vs/sessions/contrib/providers/agentHost/browser/mobile/mobileChatInputConfigPicker.ts Wires mobile agent-host config picker into the scoped service.

Copilot's findings

  • Files reviewed: 10/10 changed files
  • Comments generated: 1

Comment thread src/vs/sessions/contrib/chat/browser/slashCommands.ts
@justschen justschen marked this pull request as ready for review May 18, 2026 16:43
@justschen justschen merged commit ada6c2e into main May 18, 2026
29 checks passed
@justschen justschen deleted the justin/crabominable branch May 18, 2026 17:14
@vs-code-engineering vs-code-engineering Bot added this to the 1.122.0 milestone May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants