fix: guard activeTabGroup access in copilot diffState (fixes #317055)

[vs-code-engineering]

🔧 Error Fix

Summary

The copilot extension's DiffStateManager._updateContext() method throws Assertion Failed: Argument is \undefined` or `null`.when accessingvscode.window.tabGroups.activeTabGroupduring tab operation events. TheactiveTabGroupgetter usesassertReturnsDefinedinternally, which throws when the internal_activeGroupId` doesn't match any group in the tab groups array — a transient state that can occur during tab close/move operations before the active group ID is reconciled.

Affects 640+ users across darwin and linux platforms.

Fixes #317055
Recommended reviewer: @DonJayamanne

Culprit Commit

The diffState.ts file with setupContextTracking was introduced in commit c1c606c by @DonJayamanne (Feb 27, 2026). The _updateContext method subscribes to onDidChangeTabs events and accesses activeTabGroup without guarding against the assertion. This is a new regression in copilot extension version 0.49.2026051504 vs baseline 0.48.1.

Code Flow

sequenceDiagram
    participant MT as MainThread
    participant EH as ExtHostEditorTabs
    participant EV as EventEmitter
    participant CP as CopilotDiffState

    MT->>EH: $acceptTabOperation(operation)
    EH->>EH: group.acceptTabOperation(operation)
    EH->>EV: _onDidChangeTabs.fire(event)
    EV->>CP: _updateContext()
    CP->>EH: tabGroups.activeTabGroup [getter]
    EH->>EH: assertReturnsDefined(find by _activeGroupId)
    Note over EH: THROWS when _activeGroupId is stale

Loading

Affected Files

File	Role
extensions/copilot/src/extension/chatSessions/copilotcli/vscode-node/diffState.ts	Extension code that accesses activeTabGroup unsafely
src/vs/workbench/api/common/extHostEditorTabs.ts	Core API that throws assertion on stale _activeGroupId

Repro Steps

1. Open VS Code with copilot extension active
2. Have multiple tabs open in a tab group
3. Rapidly close tabs or move tabs between groups
4. The onDidChangeTabs event fires during a state transition where _activeGroupId is temporarily inconsistent with the groups array
5. _updateContext() accesses activeTabGroup which throws

How the Fix Works

Chosen approach (extensions/copilot/src/extension/chatSessions/copilotcli/vscode-node/diffState.ts):

Replaced the direct vscode.window.tabGroups.activeTabGroup access (which internally calls assertReturnsDefined) with vscode.window.tabGroups.all.find(g => g.isActive). This returns undefined instead of throwing when no active group is found. Added a guard clause if (!activeTabGroup) return to bail out early. This fixes at the data producer — the extension code that creates the unsafe access pattern — rather than patching the core API's assertion.

Alternatives considered: Wrapping the access in try/catch was rejected because it hides the bug instead of fixing the data producer. Modifying the core activeTabGroup getter to return undefined instead of throwing was rejected because it would break the API contract for all consumers and mask other bugs.

Recommended Owner

@DonJayamanne — author of the diffState.ts file and the setupContextTracking method that introduced this code path.

Generated by errors-fix · ● 42.5M · ◷

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.