fix restoring a session on restart#317166
Merged
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is intended to fix restoring the last active agent session on restart within the Agents window sessions layer.
Changes:
- Adjustes
restoreLastActiveSession()’s “wait until session becomes available” logic to only react to provider registration changes.
Show a summary per file
| File | Description |
|---|---|
src/vs/sessions/services/sessions/browser/sessionsManagementService.ts |
Modifies the restore wait loop by removing the onDidChangeSessions trigger used to retry restore attempts. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
686
to
691
| } | ||
| }; | ||
|
|
||
| disposables.add(this.onDidChangeSessions(() => tryRestore())); | ||
| disposables.add(this.sessionsProvidersService.onDidChangeProviders(() => tryRestore())); | ||
|
|
||
| // Call immediately in case the session became available between the |
deepak1556
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.