Skip to content

fix: enhance request validation for CopilotCLI session type#317266

Merged
DonJayamanne merged 2 commits into
mainfrom
don/incredible-squid
May 19, 2026
Merged

fix: enhance request validation for CopilotCLI session type#317266
DonJayamanne merged 2 commits into
mainfrom
don/incredible-squid

Conversation

@DonJayamanne
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 19, 2026 07:31
@DonJayamanne DonJayamanne self-assigned this May 19, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens the model/mode preselection logic in ChatInputPart by adding an early-return guard intended to scope “preselect from session history” behavior to Copilot CLI sessions.

Changes:

  • Import SessionType from chatSessionsService.
  • Add a Copilot CLI session-type check before using request history to preselect mode/model.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts Adds a Copilot CLI-only guard to session-history-based model/mode preselection.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@DonJayamanne DonJayamanne marked this pull request as ready for review May 19, 2026 08:11
@DonJayamanne DonJayamanne merged commit 4df59e8 into main May 19, 2026
25 checks passed
@DonJayamanne DonJayamanne deleted the don/incredible-squid branch May 19, 2026 09:10
@vs-code-engineering vs-code-engineering Bot added this to the 1.122.0 milestone May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants