Focus input on widget click outside textarea and action bar#317271
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Agents Window’s agent feedback overlay input widget so that clicking on the widget background (outside the textarea and action bar) focuses the textarea, making it easier to start typing feedback without precisely clicking inside the input.
Changes:
- Add a widget-level mouse interaction handler to focus the textarea when clicking on non-interactive areas of the overlay.
- Exclude clicks that originate from the textarea itself or the action bar container.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorInputContribution.ts | Adds a widget-level pointer/mouse interaction to focus the feedback textarea when clicking on the widget background. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
+99
to
+111
| // Focus the input when clicking anywhere on the widget that isn't the | ||
| // textarea itself or the action bar (e.g. padding around the textarea). | ||
| this._register(addStandardDisposableListener(this._domNode, 'mousedown', e => { | ||
| const target = e.target as Node | null; | ||
| if (target === this._inputElement) { | ||
| return; | ||
| } | ||
| if (actionsContainer.contains(target)) { | ||
| return; | ||
| } | ||
| e.preventDefault(); | ||
| this._inputElement.focus(); | ||
| })); |
aeschli
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Focus the input element when clicking on the widget outside the textarea and action bar.fixes #311997