agentHost: enable subagent integration test for Claude real SDK#317353
Merged
Conversation
- Refactor IRealSdkProviderConfig.subagentToolName (string) to subagentToolNames (readonly string[]) so providers that expose multiple subagent-kind tools can list them all. - Claude registers both 'Task' and 'Agent' as subagent tools; the model may pick either. Listing both exempts both from the 'parent must not contain inner tool calls' assertion. - Flip supportsSubagents to true for Claude now that subagent routing works end-to-end.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the shared real-SDK subagent routing integration test for Claude by allowing provider configs to declare multiple subagent-spawning tool names.
Changes:
- Replaces the single
subagentToolNameconfig withsubagentToolNames. - Updates the shared subagent test to prompt with the first tool name and exempt all configured subagent tools from parent-session inner-tool assertions.
- Enables Claude subagent support with both
TaskandAgent, while updating Copilot to the new array shape.
Show a summary per file
| File | Description |
|---|---|
src/vs/platform/agentHost/test/node/protocol/realSdkTestHelpers.ts |
Generalizes shared real-SDK subagent test configuration and assertions for multiple subagent tool names. |
src/vs/platform/agentHost/test/node/protocol/copilotRealSdk.integrationTest.ts |
Updates Copilot real-SDK config to use subagentToolNames. |
src/vs/platform/agentHost/test/node/protocol/claudeRealSdk.integrationTest.ts |
Enables Claude shared subagent testing and lists both Claude subagent tool names. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
rzhao271
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that subagent routing is wired up for Claude, enable the shared subagent integration test for the Claude real-SDK suite.
Changes
IRealSdkProviderConfig.subagentToolName(string) tosubagentToolNames(readonly string[]) so providers that expose multiple subagent-kind tools can list them all. The first entry is used in the test prompt; all entries are exempted from the parent must not contain inner tool calls assertion.TaskandAgentas subagent-kind tools (seeclaudeToolDisplay.ts) and the model may pick either when asked to spawn a subagent. List both.supportsSubagents: truefor the Claude config.['task']).Verification
Both real-SDK suites pass end-to-end with
AGENT_HOST_REAL_SDK=1: