Add ExecutionPolicy Bypass for powershell hooks#317383
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Copilot extension’s hook execution on Windows to explicitly invoke PowerShell with -ExecutionPolicy Bypass when the system shell is cmd.exe, aligning hook behavior with environments where PowerShell execution policy would otherwise block hook scripts.
Changes:
- Refactors hook process creation to derive
{ command, args, shell, env }via a newgetShellCommand(...)helper. - On Windows +
ComSpec=cmd.exe, runspowershell.exedirectly with-ExecutionPolicy Bypass(and disables PowerShell update checks). - Adds unit tests covering shell selection behavior across Windows/non-Windows scenarios.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/platform/chat/node/hookExecutor.ts | Refactors hook spawning to select a shell strategy and adds PowerShell -ExecutionPolicy Bypass for the Windows cmd.exe case. |
| extensions/copilot/src/platform/chat/test/node/hookExecutor.spec.ts | Adds tests asserting the selected shell/command/args for Windows vs non-Windows hook execution. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 3
justschen
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #315830