Add granular provider group management actions to Manage Models#317419
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the Manage Models experience in the chat workbench by replacing the single provider-group “Configure…” affordance with more granular provider-group management actions that are conditionally shown based on the provider’s configuration schema.
Changes:
- Added new
ILanguageModelsServiceAPIs for provider-group management (rename, update API key, add model, open settings). - Extended language models configuration parsing to track the
modelsarray range and support targeted snippet insertion into either the group object or themodelsarray. - Updated Manage Models UI to surface the new actions (Update API Key, Add Model, Go to Settings, Rename, Delete) and added test coverage for the new behaviors.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/common/languageModels.ts | Updates the null service stub to satisfy the expanded ILanguageModelsService interface. |
| src/vs/workbench/contrib/chat/test/common/languageModels.test.ts | Adds unit tests covering provider-group management behaviors (rename, API key update, add model snippet targeting, open settings). |
| src/vs/workbench/contrib/chat/test/browser/languageModelsConfiguration.test.ts | Adds a parsing test validating the newly tracked modelsRange. |
| src/vs/workbench/contrib/chat/test/browser/chatManagement/chatModelsViewModel.test.ts | Updates mock service to satisfy the expanded ILanguageModelsService interface. |
| src/vs/workbench/contrib/chat/common/languageModelsConfiguration.ts | Extends configuration types to support snippetTarget and modelsRange. |
| src/vs/workbench/contrib/chat/common/languageModels.ts | Implements new provider-group management APIs and refactors snippet generation helpers. |
| src/vs/workbench/contrib/chat/browser/languageModelsConfigurationService.ts | Enables snippet insertion targeting either the group range or the models array range; parses and maintains modelsRange. |
| src/vs/workbench/contrib/chat/browser/chatManagement/chatModelsWidget.ts | Replaces the single provider-group “Configure…” action with granular provider-group management actions in the UI. |
Copilot's findings
- Files reviewed: 8/8 changed files
- Comments generated: 2
Yoyokrazy
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the single "Configure" action for provider groups with specific actions: Update API Key, Add Model, Go to the config file, Rename, and Delete. Actions are shown based on the provider's configuration schema.
