fix: update github-issues notebooks to use OR between repo filters#317552
Open
haneel-kumar wants to merge 2 commits into
Open
fix: update github-issues notebooks to use OR between repo filters#317552haneel-kumar wants to merge 2 commits into
haneel-kumar wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Issue Notebook repo-filter macros to accommodate GitHub’s breaking change where whitespace-separated repo: qualifiers are no longer treated as an implicit multi-repo OR.
Changes:
- Updated
$REPOS/$reposmacro definitions to use explicitORbetweenrepo:filters. - Modified notebook JSON content in both notebooks as part of the update.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.vscode/notebooks/my-work.github-issues |
Updates $REPOS to use OR between repos, but the file content now appears truncated/invalid JSON. |
.vscode/notebooks/grooming.github-issues |
Updates $repos to use OR between repos, but one query string appears truncated/invalid JSON. |
Comments suppressed due to low confidence (2)
.vscode/notebooks/my-work.github-issues:37
- The notebook file appears truncated/invalid: it ends after the last cell object and does not include the closing
]for the top-level array. This will prevent the notebook from loading/parsing; please restore the missing content and ensure the file is valid JSON.
"kind": 2,
"language": "github-issues",
"value": "$REPOS assignee:@me is:open label:bug\n"
},
.vscode/notebooks/grooming.github-issues:31
- This
valuestring is cut off at-label:inlinand is missing the remainder of the query and the terminating quote, which makes the notebook invalid JSON and breaks the query. Please restore the full label exclusion list and ensure the string is properly closed/escaped.
"kind": 2,
"language": "github-issues",
"value": "repo:microsoft/vscode assignee:$assignee is:open type:issue -label:\"info-needed\" -label:api -label:api-finalization -label:api-proposal -label:authentication -label:bisect-ext -label:bracket-pair-colorization -label:bracket-pair-guides -label:breadcrumbs -label:callhierarchy -label:chrome-devtools -label:cloud-changes -label:code-lens -label:command-center -label:comments -label:config -label:containers -label:context-keys -label:continue-working-on -label:css-less-scss -label:custom-editors -label:debug -label:debug-disassembly -label:dialogs -label:diff-editor -label:dropdown -label:editor-api -label:editor-autoclosing -label:editor-autoindent -label:editor-bracket-matching -label:editor-clipboard -label:editor-code-actions -label:editor-color-picker -label:editor-columnselect -label:editor-commands -label:editor-comments -label:editor-contrib -label:editor-core -label:editor-drag-and-drop -label:editor-error-widget -label:editor-find -label:editor-folding -label:editor-highlight -label:editor-hover -label:editor-indent-detection -label:editor-indent-guides -label:editor-input -label:editor-input-IME -label:editor-insets -label:editor-minimap -label:editor-multicursor -label:editor-parameter-hints -label:editor-render-whitespace -label:editor-rendering -label:editor-widgets -label:editor-RTL -label:editor-scrollbar -label:editor-sorting -label:editor-sticky-scroll -label:editor-symbols -label:editor-synced-region -label:editor-textbuffer -label:editor-theming -label:editor-wordnav -label:editor-wrapping -label:emmet -label:emmet-parse -label:error-list -label:extension-activation -label:extension-host -label:extension-prerelease -label:extension-recommendations -label:extensions -label:extensions-development -label:file-decorations -label:file-encoding -label:file-explorer -label:file-glob -label:file-io -label:file-nesting -label:file-watcher -label:font-rendering -label:formatting -label:getting-started -label:ghost-text -label:git -label:github -label:github-repositories -label:gpu -label:grammar -label:grid-widget -label:html -label:icon-brand -label:icons-product -label:image-preview -label:inlay-hints -label:inlin
},
| "kind": 2, | ||
| "language": "github-issues", | ||
| "value": "// list of repos we work in\n$REPOS=repo:microsoft/lsprotocol repo:microsoft/monaco-editor repo:microsoft/vscode repo:microsoft/vscode-anycode repo:microsoft/vscode-autopep8 repo:microsoft/vscode-black-formatter repo:microsoft/vscode-copilot repo:microsoft/vscode-copilot-release repo:microsoft/vscode-dev repo:microsoft/vscode-dev-chrome-launcher repo:microsoft/vscode-emmet-helper repo:microsoft/vscode-extension-telemetry repo:microsoft/vscode-flake8 repo:microsoft/vscode-github-issue-notebooks repo:microsoft/vscode-hexeditor repo:microsoft/vscode-internalbacklog repo:microsoft/vscode-isort repo:microsoft/vscode-js-debug repo:microsoft/vscode-jupyter repo:microsoft/vscode-jupyter-internal repo:microsoft/vscode-l10n repo:microsoft/vscode-livepreview repo:microsoft/vscode-markdown-languageservice repo:microsoft/vscode-markdown-tm-grammar repo:microsoft/vscode-mypy repo:microsoft/vscode-pull-request-github repo:microsoft/vscode-pylint repo:microsoft/vscode-python repo:microsoft/vscode-python-debugger repo:microsoft/vscode-python-tools-extension-template repo:microsoft/vscode-references-view repo:microsoft/vscode-remote-release repo:microsoft/vscode-remote-repositories-github repo:microsoft/vscode-remote-tunnels repo:microsoft/vscode-remotehub repo:microsoft/vscode-settings-sync-server repo:microsoft/vscode-unpkg repo:microsoft/vscode-vsce repo:microsoft/vscode-copilot-issues repo:microsoft/vscode-extension-samples\n\n// current milestone name\n$MILESTONE=milestone:\"1.114.0\"\n" | ||
| "value": "// list of repos we work in\n$REPOS=repo:microsoft/lsprotocol OR repo:microsoft/monaco-editor OR repo:microsoft/vscode OR repo:microsoft/vscode-anycode OR repo:microsoft/vscode-autopep8 OR repo:microsoft/vscode-black-formatter OR repo:microsoft/vscode-copilot OR repo:microsoft/vscode-copilot-release OR repo:microsoft/vscode-dev OR repo:microsoft/vscode-dev-chrome-launcher OR repo:microsoft/vscode-emmet-helper OR repo:microsoft/vscode-extension-telemetry OR repo:microsoft/vscode-flake8 OR repo:microsoft/vscode-github-issue-notebooks OR repo:microsoft/vscode-hexeditor OR repo:microsoft/vscode-internalbacklog OR repo:microsoft/vscode-isort OR repo:microsoft/vscode-js-debug OR repo:microsoft/vscode-jupyter OR repo:microsoft/vscode-jupyter-internal OR repo:microsoft/vscode-l10n OR repo:microsoft/vscode-livepreview OR repo:microsoft/vscode-markdown-languageservice OR repo:microsoft/vscode-markdown-tm-grammar OR repo:microsoft/vscode-mypy OR repo:microsoft/vscode-pull-request-github OR repo:microsoft/vscode-pylint OR repo:microsoft/vscode-python OR repo:microsoft/vscode-python-debugger OR repo:microsoft/vscode-python-tools-extension-template OR repo:microsoft/vscode-references-view OR repo:microsoft/vscode-remote-release OR repo:microsoft/vscode-remote-repositories-github OR repo:microsoft/vscode-remote-tunnels OR repo:microsoft/vscode-remotehub OR repo:microsoft/vscode-settings-sync-server OR repo:microsoft/vscode-unpkg OR repo:microsoft/vscode-vsce OR repo:microsoft/vscode-copilot-issues OR repo:microsoft/vscode-extension-samples\n\n// current milestone name\n$MILESTONE=milestone:\"1.114.0\"\n" |
| "kind": 2, | ||
| "language": "github-issues", | ||
| "value": "// list of repos we work in\r\n$repos=repo:microsoft/lsprotocol repo:microsoft/monaco-editor repo:microsoft/vscode repo:microsoft/vscode-anycode repo:microsoft/vscode-autopep8 repo:microsoft/vscode-black-formatter repo:microsoft/vscode-copilot repo:microsoft/vscode-copilot-release repo:microsoft/vscode-dev repo:microsoft/vscode-dev-chrome-launcher repo:microsoft/vscode-emmet-helper repo:microsoft/vscode-extension-telemetry repo:microsoft/vscode-flake8 repo:microsoft/vscode-github-issue-notebooks repo:microsoft/vscode-hexeditor repo:microsoft/vscode-internalbacklog repo:microsoft/vscode-isort repo:microsoft/vscode-js-debug repo:microsoft/vscode-jupyter repo:microsoft/vscode-jupyter-internal repo:microsoft/vscode-l10n repo:microsoft/vscode-livepreview repo:microsoft/vscode-markdown-languageservice repo:microsoft/vscode-markdown-tm-grammar repo:microsoft/vscode-mypy repo:microsoft/vscode-pull-request-github repo:microsoft/vscode-pylint repo:microsoft/vscode-python repo:microsoft/vscode-python-debugger repo:microsoft/vscode-python-tools-extension-template repo:microsoft/vscode-references-view repo:microsoft/vscode-remote-release repo:microsoft/vscode-remote-repositories-github repo:microsoft/vscode-remote-tunnels repo:microsoft/vscode-remotehub repo:microsoft/vscode-settings-sync-server repo:microsoft/vscode-unpkg repo:microsoft/vscode-vsce\r\n\r\n$assignee=@me\r\n" | ||
| "value": "// list of repos we work in\r\n$repos=repo:microsoft/lsprotocol OR repo:microsoft/monaco-editor OR repo:microsoft/vscode OR repo:microsoft/vscode-anycode OR repo:microsoft/vscode-autopep8 OR repo:microsoft/vscode-black-formatter OR repo:microsoft/vscode-copilot OR repo:microsoft/vscode-copilot-release OR repo:microsoft/vscode-dev OR repo:microsoft/vscode-dev-chrome-launcher OR repo:microsoft/vscode-emmet-helper OR repo:microsoft/vscode-extension-telemetry OR repo:microsoft/vscode-flake8 OR repo:microsoft/vscode-github-issue-notebooks OR repo:microsoft/vscode-hexeditor OR repo:microsoft/vscode-internalbacklog OR repo:microsoft/vscode-isort OR repo:microsoft/vscode-js-debug OR repo:microsoft/vscode-jupyter OR repo:microsoft/vscode-jupyter-internal OR repo:microsoft/vscode-l10n OR repo:microsoft/vscode-livepreview OR repo:microsoft/vscode-markdown-languageservice OR repo:microsoft/vscode-markdown-tm-grammar OR repo:microsoft/vscode-mypy OR repo:microsoft/vscode-pull-request-github OR repo:microsoft/vscode-pylint OR repo:microsoft/vscode-python OR repo:microsoft/vscode-python-debugger OR repo:microsoft/vscode-python-tools-extension-template OR repo:microsoft/vscode-references-view OR repo:microsoft/vscode-remote-release OR repo:microsoft/vscode-remote-repositories-github OR repo:microsoft/vscode-remote-tunnels OR repo:microsoft/vscode-remotehub OR repo:microsoft/vscode-settings-sync-server OR repo:microsoft/vscode-unpkg OR repo:microsoft/vscode-vsce\r\n\r\n$assignee=@me\r\n" |
Author
|
@microsoft-github-policy-service agree |
GitHub issue query breaking change: spaces between repo: filters are now treated as AND operators. This updates grooming.github-issues to use OR between repo: filters in the $repos macro. Fixes microsoft#252667
ec55a60 to
01707c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #252667
GitHub introduced a breaking change in their issue search API: spaces between
repo:filters in multi-repo queries are now treated asANDoperators instead of being treated as separate repos.This PR updates the GitHub Issue Notebooks in
.vscode/notebooks/to use explicitORbetweenrepo:filters in the$repos/$REPOSmacro definitions.Files Changed
.vscode/notebooks/grooming.github-issues— updated$repos=macro.vscode/notebooks/my-work.github-issues— updated$REPOS=macroTesting
The queries in the affected notebooks now use
ORbetween repo filters, matching the updated GitHub API syntax.