Default reasoning effort to first advertised level for unspecified families#317622
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Copilot language model configuration schema so the “Thinking Effort” picker always has a concrete default value when a model family doesn’t define (or doesn’t support) a preferred default, avoiding an undefined default selection.
Changes:
- Adds a fallback to use the first advertised
supportsReasoningEffortlevel when no family-specific default can be chosen.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/conversation/vscode-node/languageModelAccess.ts | Ensures reasoningEffort schema defaults to the first supported effort level when no explicit default applies. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
dmitrivMS
previously approved these changes
May 20, 2026
dmitrivMS
previously approved these changes
May 21, 2026
dmitrivMS
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Falls back to the first advertised effort level when the model family doesn't have an explicit default, so the picker shows a real level instead of 'undefined'.