test(mcp): silence sinon FakeTimers native-timer warning in sampling log tests#317631
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a flaky Electron renderer test run failure caused by Sinon's FakeTimers emitting a console.warn during teardown, which violates the renderer harness’ “no unexpected console output” assertion.
Changes:
- Configure the
MCP - Sampling Logtest suite’s fake timers withshouldClearNativeTimers: trueto prevent warnings whenclearTimeoutis called with native timer IDs created outside the fake clock.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/mcp/test/common/mcpSamplingLog.test.ts | Updates the suite’s sinon.useFakeTimers() configuration to silence native-timer clear warnings that can fail the renderer test harness. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
rzhao271
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flaky failure seen in Insider build 440965 (macOS → Electron Tests):
The actual
MCP - Sampling Log > handles different content typestest passed (✔). TheafterEachhook intest/unit/electron/renderer.jsfailed because Sinon's FakeTimers library wrote to the console during the run:This happens when
clearTimeoutis called with a native timer ID while the fake clock is installed — typically a cross-test interaction where a timer scheduled outside this suite is cleaned up while sinon's fakeclearTimeoutis active.This PR passes
{ shouldClearNativeTimers: true }tosinon.useFakeTimers()in the suite, which tells the library to silently delegate such calls to the realclearTimeoutinstead of emittingconsole.warn. It eliminates the spurious failure without changing any test behavior.Verified locally:
scripts/test.bat --run src/vs/workbench/contrib/mcp/test/common/mcpSamplingLog.test.ts→ 7 passing.