Only surface "sort imports" and "remove unused imports" when TS client is running/useTsgo is not active#317656
Merged
Merged
Conversation
…t is running/useTsgo is not active Fixes #317413
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the built-in TypeScript/JavaScript extension’s command contributions so “Sort Imports” and “Remove Unused Imports” are only shown when the built-in TS workflow is active (i.e. not using useTsgo), addressing the conflict described in #317413.
Changes:
- Adds
useTsgo+typescript.isManagedFilegating to the command palette visibility of the four sort/remove import commands. - Adds
enablementexpressions to the four command contributions to disable them whenuseTsgois enabled.
Show a summary per file
| File | Description |
|---|---|
| extensions/typescript-language-features/package.json | Gates sort/remove-imports command visibility (and now enablement) on useTsgo being off and on the managed-file context. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
2892
to
+2914
| { | ||
| "command": "typescript.sortImports", | ||
| "title": "%typescript.sortImports%", | ||
| "category": "TypeScript" | ||
| "category": "TypeScript", | ||
| "enablement": "!config.js/ts.experimental.useTsgo && !config.typescript.experimental.useTsgo && typescript.isManagedFile" | ||
| }, | ||
| { | ||
| "command": "javascript.sortImports", | ||
| "title": "%typescript.sortImports%", | ||
| "category": "JavaScript" | ||
| "category": "JavaScript", | ||
| "enablement": "!config.js/ts.experimental.useTsgo && !config.typescript.experimental.useTsgo && typescript.isManagedFile" | ||
| }, | ||
| { | ||
| "command": "typescript.removeUnusedImports", | ||
| "title": "%typescript.removeUnusedImports%", | ||
| "category": "TypeScript" | ||
| "category": "TypeScript", | ||
| "enablement": "!config.js/ts.experimental.useTsgo && !config.typescript.experimental.useTsgo && typescript.isManagedFile" | ||
| }, | ||
| { | ||
| "command": "javascript.removeUnusedImports", | ||
| "title": "%typescript.removeUnusedImports%", | ||
| "category": "JavaScript" | ||
| "category": "JavaScript", | ||
| "enablement": "!config.js/ts.experimental.useTsgo && !config.typescript.experimental.useTsgo && typescript.isManagedFile" |
DonJayamanne
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #317413