fix: remove unsupported decommit_pooled_pages flag#317794
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a Linux-only V8/Node JS flag injection from VS Code’s Electron bootstrap (src/main.ts) that is no longer supported after the Chromium M134 update, addressing Ubuntu failures where forked Node processes exit immediately.
Changes:
- Removes the Linux-specific
--nodecommit_pooled_pagesflag from the computed JS flags list ingetJSFlags.
justschen
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #302602
Flag missed removal after M134 update.