Revert: Use copilot/copilot-utility-small for terminal-tool steering messages#317812
Merged
Conversation
This reverts PR #317389. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts prior work that routed terminal-tool steering messages (background completion, input-needed, terminal-exited) through the copilot/copilot-utility-small alias, restoring behavior where these steering requests inherit the conversation request’s model.
Changes:
- Remove
ILanguageModelsServiceusage and the utility-small model resolution path fromRunInTerminalTool. - Send terminal steering
sendRequestcalls directly with the captured conversation send options (model/mode/tools). - Simplify
RunInTerminalToolunit tests by removing the async flush helper and converting affected tests back to synchronous.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts | Removes utility-small alias resolution and reverts steering-message model selection to inherit the conversation request’s model. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/electron-browser/runInTerminalTool.test.ts | Drops the ILanguageModelsService stub and the microtask-flush helper; updates steering-notification tests to assert synchronously. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
roblourens
changed the title
rzhao271
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert #317389