Add browser emulation toolbar#317831
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a device-emulation toolbar and supporting plumbing for the integrated browser editor, enabling viewport sizing, DPR/user-agent/mobile toggles, and interactive resize handles that drive Chromium’s device emulation.
Changes:
- Introduces a browser editor emulation contribution with toolbar UI, context keys, actions, and resize sashes.
- Extends the browser view model/service contracts to support device profiles and screen emulation bounds.
- Updates browser editor layout to support contribution-driven container sizing + emulation data pushed to the main process.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/browserView/electron-browser/media/browser.css | Adds styles for the emulation toolbar and resize sashes; adjusts container wrapper layout to flex-center the viewport. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserEditorEmulationFeatures.ts | New emulation toolbar + contribution, including actions (presets/UA/mobile/reset) and interactive resizing. |
| src/vs/workbench/contrib/browserView/electron-browser/browserViewActions.ts | Adds a “Developer” action group to place emulation-related actions. |
| src/vs/workbench/contrib/browserView/electron-browser/browserView.contribution.ts | Wires the emulation feature into the browser view contribution entrypoint. |
| src/vs/workbench/contrib/browserView/electron-browser/browserEditor.ts | Adds container-ready/layout override hooks for contributions and pushes emulation bounds through layout calls. |
| src/vs/workbench/contrib/browserView/common/browserView.ts | Extends the workbench-side model with device, device-change event, and setDevice. |
| src/vs/platform/browserView/electron-main/browserViewMainService.ts | Exposes device-emulation event + setter on the main-process browser view service. |
| src/vs/platform/browserView/electron-main/browserViewEmulator.ts | New main-process emulator applying UA/touch/media overrides and Chromium device emulation settings. |
| src/vs/platform/browserView/electron-main/browserView.ts | Instantiates the emulator, includes device in state, and applies screen emulation during layout. |
| src/vs/platform/browserView/common/browserView.ts | Extends shared contracts: emulation bounds, device/screen profile types, service event + method. |
| src/vs/platform/actions/common/actions.ts | Adds MenuId.BrowserEmulationToolbar for the toolbar action menu. |
Copilot's findings
- Files reviewed: 11/11 changed files
- Comments generated: 2
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
dmitrivMS
previously approved these changes
May 21, 2026
dmitrivMS
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.