fix: memory leak in storageMainService

[SimonSiefke]

Fixes a memory leak in storageMainService.

Details

In storageMainService, when a window is loaded, the profile storage and workspace storage for that window are intialized:

this._register(this.lifecycleMainService.onWillLoadWindow(e => {

	// Profile Storage: Warmup when related window with profile loads
	if (e.window.profile) {
		this.profileStorage(e.window.profile).init();
	}

	// Workspace Storage: Warmup when related window with workspace loads
	if (e.workspace) {
		this.workspaceStorage(e.workspace).init();
	}
}

But it seems the profile storage and workspace storage aren't being closed their window closes.

Changes

The change ensures when a window is closed, that its profile storage and workspace storage are closed as well:

this._register(this.lifecycleMainService.onWillLoadWindow(e => {

	// Profile Storage: Warmup when related window with profile loads
	if (e.window.profile) {
		this.profileStorage(e.window.profile).init();
	}

	// Workspace Storage: Warmup when related window with workspace loads
	if (e.workspace) {
		this.workspaceStorage(e.workspace).init();
	}


	Event.once(Event.any(e.window.onDidClose, e.window.onDidDestroy))(async () => {
		if (this.shutdownReason) {
			return;
		}
		if (e.window.profile && this.mapProfileToStorage.has(e.window.profile.id)) {
			await this.profileStorage(e.window.profile).close();
		}
		const actualWorkspace = e.workspace ?? e.window.openedWorkspace ?? toWorkspaceIdentifier(e.window.backupPath, e.window.isExtensionDevelopmentHost);
		if (actualWorkspace && this.mapWorkspaceToStorage.has(actualWorkspace.id)) {
			await this.workspaceStorage(actualWorkspace).close();
		}
	});
}));

---

Also this code

workspaceStorage = this._register(this.createWorkspaceStorage(workspace));
this.mapWorkspaceToStorage.set(workspace.id, workspaceStorage);

is changed to

workspaceStorage = this.createWorkspaceStorage(workspace);
this.mapWorkspaceToStorage.set(workspace.id, workspaceStorage);

because adding the storage disposables via this._register would only remove them when the storageMainService shuts down. instead of when the window closes.

Before

When opening and closing a new window 17 times, the number of storageMainService functions seems to grow each time:

After

When opening and closing a new window 17 times, the number of storageMainService function stays constant:

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR updates the Electron main-process storage lifecycle to proactively close profile/workspace storages when a window closes, and adjusts how storages are instantiated and tracked.

Changes:

• Add window close/destroy hook to close associated profile/workspace storages.
• Introduce toWorkspaceIdentifier usage to derive a workspace identifier for closing.
• Stop registering created profile/workspace storage instances with _register().