fix(chat): add JSON schema type and validation for chatLanguageModels configuration#317881
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves JSON schema support for the chatLanguageModels.json user/profile configuration file and normalizes Copilot BYOK provider configuration schemas so they validate as explicit objects.
Changes:
- Adds JSON schema associations so
chatLanguageModels.json(default + per-profile) gets IntelliSense/validation when opened directly. - Updates Copilot extension BYOK provider
configurationschemas (Anthropic, xAI, Google Gemini, OpenRouter, OpenAI) to explicitly declaretype: "object".
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/package.json | Declares BYOK provider configuration blocks as JSON schema objects to improve validation/consistency. |
| extensions/configuration-editing/package.json | Associates chatLanguageModels.json (default and profiles) with vscode://schemas/language-models for schema-backed editing. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
TylerLeonhardt
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds JSON schema associations for chatLanguageModels.json profile files so the language models configuration file receives schema-backed IntelliSense, validation, and completions when opened directly.
Also normalizes native BYOK provider configuration schemas in the Copilot extension by declaring their API-key configuration blocks as explicit objects.