Decode image name for display in carousel#317885
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a chat attachment display issue where percent-encoded image filenames (e.g. Element%20Screenshot) appear encoded in the Images Preview carousel/editor title.
Changes:
- Decode the last URI path segment via
decodeURIComponentwhen building single-image carousel arguments. - Preserve existing behavior for invalid percent-encoding by falling back to the raw segment.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/chatImageCarouselService.ts | Decodes the image name extracted from the URI path so titles/labels display a human-readable filename in the carousel. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
jruales
previously approved these changes
May 21, 2026
Co-authored-by: kycutler <67761731+kycutler@users.noreply.github.com>
TylerLeonhardt
approved these changes
May 25, 2026
dileepyavan
pushed a commit
that referenced
this pull request
May 27, 2026
* Decode image name for display in carousel * Add test for percent-encoded carousel image names Co-authored-by: kycutler <67761731+kycutler@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #317135
Likely regressed with #308128