Defer Copilot Steering Consumption Signals#317888
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Moves Copilot steering “consumed” signaling into CopilotAgentSession so steering messages remain visible until the SDK turn progresses (next top-level tool start), the turn completes, or the turn is aborted—addressing the UX issue where steering disappeared too early.
Changes:
- Defers
steering_consumedemission by queueing consumed IDs and flushing them on top-level tool start, turn completion, or abort. - Deduplicates steering sends by tracking in-flight and deferred-consumed steering message IDs.
- Updates/adds unit tests to validate deferred flushing behavior, duplicate suppression, and abort flushing.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts | Adds in-flight/consumed tracking and deferred flushing of steering_consumed on tool start/turn complete/abort. |
| src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts | Updates sendSteering tests to assert deferred consumption timing and duplicate suppression behavior. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
roblourens
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves Copilot steering consumption signaling into
CopilotAgentSessionso steering messages stay visible until the Copilot SDK response resumes with a top-level tool call or the turn completes.Summary:
steering_consumedsignals on the next top-level tool start, turn completion, or abort.Fixes #317877