Skip to content

Defer Copilot Steering Consumption Signals#317888

Merged
connor4312 merged 1 commit into
mainfrom
connor/defer-copilot-steering-consumption
May 22, 2026
Merged

Defer Copilot Steering Consumption Signals#317888
connor4312 merged 1 commit into
mainfrom
connor/defer-copilot-steering-consumption

Conversation

@connor4312
Copy link
Copy Markdown
Member

This moves Copilot steering consumption signaling into CopilotAgentSession so steering messages stay visible until the Copilot SDK response resumes with a top-level tool call or the turn completes.

Summary:

  • Deduplicate in-flight and already-consumed steering messages before sending to the SDK.
  • Flush deferred steering_consumed signals on the next top-level tool start, turn completion, or abort.
  • Add focused tests for deferred flushing, duplicate sends, and abort behavior.

Fixes #317877

Copilot AI review requested due to automatic review settings May 22, 2026 00:00
@connor4312 connor4312 enabled auto-merge (squash) May 22, 2026 00:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves Copilot steering “consumed” signaling into CopilotAgentSession so steering messages remain visible until the SDK turn progresses (next top-level tool start), the turn completes, or the turn is aborted—addressing the UX issue where steering disappeared too early.

Changes:

  • Defers steering_consumed emission by queueing consumed IDs and flushing them on top-level tool start, turn completion, or abort.
  • Deduplicates steering sends by tracking in-flight and deferred-consumed steering message IDs.
  • Updates/adds unit tests to validate deferred flushing behavior, duplicate suppression, and abort flushing.
Show a summary per file
File Description
src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts Adds in-flight/consumed tracking and deferred flushing of steering_consumed on tool start/turn complete/abort.
src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts Updates sendSteering tests to assert deferred consumption timing and duplicate suppression behavior.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 1

Comment thread src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts
@connor4312 connor4312 merged commit 2832948 into main May 22, 2026
26 checks passed
@connor4312 connor4312 deleted the connor/defer-copilot-steering-consumption branch May 22, 2026 00:30
@vs-code-engineering vs-code-engineering Bot added this to the 1.122.0 milestone May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

steering message disappears on AHP chat session

3 participants