Update default dark and light themes to Modern For better styling #317911
Open
DevFlex-AI wants to merge 1 commit into
Open
Update default dark and light themes to Modern For better styling #317911DevFlex-AI wants to merge 1 commit into
DevFlex-AI wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the default workbench theme names and adjusts the initial color token values for the built-in dark/light themes to align with the “Modern” variants.
Changes:
- Renamed the default theme setting values from “Dark/Light 2026” to “Dark/Light Modern”.
- Tweaked several default color tokens (adding status bar hover tokens, adjusting button/tab tokens, removing some explicit defaults).
Comment on lines
+83
to
+88
| 'button.border': '#ffffff1a', | ||
| 'button.foreground': '#FFFFFF', | ||
| 'button.hoverBackground': '#026EC1', | ||
| 'button.secondaryBackground': '#313131', | ||
| 'button.secondaryBackground': '#00000000', | ||
| 'button.secondaryForeground': '#CCCCCC', | ||
| 'button.secondaryHoverBackground': '#3C3C3C', | ||
| 'button.secondaryHoverBackground': '#2B2B2B', |
Comment on lines
+42
to
+43
| export const COLOR_THEME_DARK = 'Dark Modern'; | ||
| export const COLOR_THEME_LIGHT = 'Light Modern'; |
Author
I fixed some problem please review |
Comment on lines
+166
to
+167
| 'statusBarItem.hoverBackground': '#F1F1F133', | ||
| 'statusBarItem.hoverForeground': '#FFFFFF', |
Comment on lines
+305
to
+306
| 'statusBarItem.hoverBackground': '#1F1F1F11', | ||
| 'statusBarItem.hoverForeground': '#000000', |
| 'button.foreground': '#FFFFFF', | ||
| 'button.hoverBackground': '#026EC1', | ||
| 'button.secondaryBackground': '#313131', | ||
| 'button.secondaryBackground': '#00000000', |
Author
|
I am fixing these |
Comment on lines
126
to
129
| 'menu.background': '#1F1F1F', | ||
| 'menu.border': '#454545', | ||
| 'menu.foreground': '#CCCCCC', | ||
| 'menu.selectionBackground': '#0078d4', | ||
| 'menu.separatorBackground': '#454545', | ||
| 'menu.selectionBackground': '#0078D4', | ||
| 'notificationCenterHeader.background': '#1F1F1F', | ||
| 'notificationCenterHeader.foreground': '#CCCCCC', |
Comment on lines
175
to
179
| 'tab.hoverBackground': '#1F1F1F', | ||
| 'tab.inactiveBackground': '#181818', | ||
| 'tab.inactiveForeground': '#9D9D9D', | ||
| 'tab.lastPinnedBorder': '#ccc3', | ||
| 'tab.selectedBackground': '#222222', | ||
| 'tab.selectedBorderTop': '#6caddf', | ||
| 'tab.selectedForeground': '#ffffffa0', | ||
| 'tab.selectedBorderTop': '#6CADDF', | ||
| 'tab.unfocusedActiveBorder': '#1F1F1F', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Proposed Changes
This PR updates the core theme fallback constants and the initial render splash colors to align with the Dark Modern and Light Modern themes.
While the "Modern" themes have successfully become the standard visual identity for VS Code, the underlying
workbenchThemeService.tsstill relied on legacy theme defaults (Dark 2026/Light 2026) for its internal fallback states and initial color maps.By updating these constants, this PR ensures a perfectly cohesive experience in two key areas:
COLOR_THEME_DARK_INITIAL_COLORSandCOLOR_THEME_LIGHT_INITIAL_COLORSmaps have been carefully synchronized with their respectivedark_modern.jsonandlight_modern.jsoncounterparts. This guarantees that the pre-load splash screen perfectly matches the final editor UI, eliminating visual jank or color flashing during startup.Specific changes made:
ThemeSettingDefaults.COLOR_THEME_DARKto'Dark Modern'ThemeSettingDefaults.COLOR_THEME_LIGHTto'Light Modern'COLOR_THEME_DARK_INITIAL_COLORSto exactly matchDark Moderntokens.COLOR_THEME_LIGHT_INITIAL_COLORSto exactly matchLight Moderntokens.How to Test
yarn watch->./scripts/code.sh).workbench.colorThemesetting), the editor defaults to the Modern themes.window.autoDetectColorSchemeto true and verify it switches between Dark Modern and Light Modern gracefully.