Update xterm.js to 6.1.0-beta.220#317936
Draft
anthonykim1 wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the VS Code terminal’s xterm.js dependency set to newer 6.1.0 beta builds (and matching addon betas), picking up upstream fixes referenced in #317740, and adjusts the clipboard addon integration for the updated addon API surface.
Changes:
- Bump
@xterm/xtermto6.1.0-beta.220and update related@xterm/*addon versions across root/remote/web packages and lockfiles. - Adjust the clipboard addon handler typings in
XtermTerminalto match the updated@xterm/addon-clipboardtype exports.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts | Updates clipboard addon import and handler callback parameter types to align with the updated addon typings. |
| package.json | Bumps xterm.js and addons to the newer beta versions used by desktop builds. |
| package-lock.json | Lockfile refresh for updated xterm.js/addons and related dependency graph adjustments. |
| remote/package.json | Bumps xterm.js, addons, and headless xterm for remote (REH) builds. |
| remote/package-lock.json | Lockfile refresh for remote package dependency updates. |
| remote/web/package.json | Bumps xterm.js and addons for web-remote packaging. |
| remote/web/package-lock.json | Lockfile refresh for remote web package dependency updates. |
Copilot's findings
Files not reviewed (2)
- remote/package-lock.json: Language not supported
- remote/web/package-lock.json: Language not supported
- Files reviewed: 4/7 changed files
- Comments generated: 0
niclimcy
reviewed
May 22, 2026
| } | ||
| this._clipboardAddon = this._instantiationService.createInstance(ClipboardAddon, undefined, { | ||
| async readText(type: ClipboardSelectionType): Promise<string> { | ||
| async readText(type: string): Promise<string> { |
Contributor
Author
There was a problem hiding this comment.
Api shape changed.
Also what's wrong with #317927 ? Why make a new PR?
Same reason. Thanks for the interest
|
Also what's wrong with #317927 ? Why make a new PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #317740