Skip to content

Update modal background opacity to 50% for improved visibility#317973

Merged
mrleemurray merged 1 commit into
mainfrom
mrleemurray/ambitious-beige-skunk
May 22, 2026
Merged

Update modal background opacity to 50% for improved visibility#317973
mrleemurray merged 1 commit into
mainfrom
mrleemurray/ambitious-beige-skunk

Conversation

@mrleemurray
Copy link
Copy Markdown
Contributor

Enhance the visibility of modal backgrounds by updating their opacity to 50%. This change applies to various modal components across the application, ensuring a consistent user experience. Test the modals to confirm the improved visibility.

Addresses: #317691

Copilot AI review requested due to automatic review settings May 22, 2026 11:00
@mrleemurray mrleemurray enabled auto-merge (squash) May 22, 2026 11:00
@mrleemurray mrleemurray self-assigned this May 22, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates modal backdrop dimming to a consistent 50% black across key modal surfaces, aligning workbench and Sessions UI behavior with the goal in #317691.

Changes:

  • Increase modal editor backdrop opacity from 0.3 → 0.5.
  • Increase base dialog modal dimming opacity from 0.3 → 0.5.
  • Align Electron window-controls “dimmed” color blending to the 50% black overlay, and update associated inline documentation.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/vs/workbench/browser/parts/editor/media/modalEditorPart.css Raises modal editor background dimming to 50% black.
src/vs/sessions/contrib/chat/browser/media/runScriptAction.css Raises Sessions “run script” modal backdrop dimming to 50% black.
src/vs/platform/windows/electron-main/windowImpl.ts Updates window-controls dimming blend factor and comment to match 50% modal overlay.
src/vs/base/browser/ui/dialog/dialog.css Raises dialog modal dimming to 50% black.

@mrleemurray mrleemurray merged commit c583494 into main May 22, 2026
26 checks passed
@mrleemurray mrleemurray deleted the mrleemurray/ambitious-beige-skunk branch May 22, 2026 12:33
@vs-code-engineering vs-code-engineering Bot added this to the 1.122.0 milestone May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants