Update modal background opacity to 50% for improved visibility#317973
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates modal backdrop dimming to a consistent 50% black across key modal surfaces, aligning workbench and Sessions UI behavior with the goal in #317691.
Changes:
- Increase modal editor backdrop opacity from 0.3 → 0.5.
- Increase base dialog modal dimming opacity from 0.3 → 0.5.
- Align Electron window-controls “dimmed” color blending to the 50% black overlay, and update associated inline documentation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/browser/parts/editor/media/modalEditorPart.css | Raises modal editor background dimming to 50% black. |
| src/vs/sessions/contrib/chat/browser/media/runScriptAction.css | Raises Sessions “run script” modal backdrop dimming to 50% black. |
| src/vs/platform/windows/electron-main/windowImpl.ts | Updates window-controls dimming blend factor and comment to match 50% modal overlay. |
| src/vs/base/browser/ui/dialog/dialog.css | Raises dialog modal dimming to 50% black. |
lramos15
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the visibility of modal backgrounds by updating their opacity to 50%. This change applies to various modal components across the application, ensuring a consistent user experience. Test the modals to confirm the improved visibility.
Addresses: #317691