Enable agent host by default for insiders#318007
Merged
roblourens merged 3 commits intoMay 22, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the default behavior of the chat agent host feature for non-stable builds and improves remote-server behavior by always registering an agentHostProxy IPC channel, even when no upstream agent host endpoint is configured, so clients fail with a clear error instead of “Unknown channel”.
Changes:
- Enable
chat.agentHost.enabledby default whenproduct.quality !== 'stable'. - Register an
UnavailableAgentHostChannelas theagentHostProxyIPC channel when no bridge endpoint is configured. - Add server-side unit coverage for the unavailable proxy channel behavior.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts | Switches the default for chat.agentHost.enabled to be on for non-stable qualities. |
| src/vs/server/node/serverServices.ts | Registers agentHostProxy unconditionally (real proxy when configured, otherwise an unavailable proxy). |
| src/vs/server/node/agentHostChannel.ts | Adds UnavailableAgentHostChannel implementation and the explicit failure message. |
| src/vs/server/test/node/agentHostChannel.test.ts | Adds a unit test validating the unavailable-channel path and error messaging. |
Copilot's findings
- Files reviewed: 12/12 changed files
- Comments generated: 1
Contributor
|
Base:
|
Keep shared browser-layer contributions gated on the raw setting so desktop/browser tests continue to exercise their behavior, while the web runtime ignore remains in the service/client paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @deepak1556Matched files:
|
vritant24
approved these changes
May 22, 2026
roblourens
deleted the
agents/i-previously-had-the-agent-host-setting-enabled-f0bd2fe9
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chat.agentHost.enabledby default for non-stable, non-web product qualityagentHostProxychannel on server-web when no agent host bridge endpoint existsValidation
npm run compile-check-ts-nativenode --experimental-strip-types build/hygiene.ts src/vs/platform/agentHost/common/agentService.ts src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts src/vs/code/electron-main/app.ts src/vs/platform/agentHost/electron-browser/localAgentHostService.ts src/vs/workbench/services/agentHost/browser/editorRemoteAgentHostServiceClient.ts src/vs/sessions/contrib/providers/agentHost/browser/localAgentHost.contribution.ts src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostTerminalContribution.ts src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostChatContribution.ts src/vs/workbench/contrib/chat/browser/actions/exportAgentHostDebugLogsAction.tsnpm run gulp -- compile-client --silent./scripts/test.sh --run src/vs/server/test/node/agentHostChannel.test.ts