Skip to content

Issue reporter wizard: dont include settings#318301

Merged
Giuspepe merged 1 commit into
mainfrom
issue-reporter-settings
May 26, 2026
Merged

Issue reporter wizard: dont include settings#318301
Giuspepe merged 1 commit into
mainfrom
issue-reporter-settings

Conversation

@Giuspepe
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 26, 2026 07:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Issue Reporter wizard to stop collecting and attaching user settings data, reducing the amount of potentially sensitive/environment-specific information included in issue reports.

Changes:

  • Removed the “Settings” diagnostic section from the wizard’s Review step and excluded settings from the generated issue markdown.
  • Removed settings-related state and draft key serialization in the overlay.
  • Stopped reading the current profile’s settings file in the editor pane (and removed the corresponding service dependency).
Show a summary per file
File Description
src/vs/workbench/contrib/issue/browser/issueReporterOverlay.ts Removes settings toggles/content, omits settings from issue body generation and draft serialization.
src/vs/workbench/contrib/issue/browser/issueReporterEditorPane.ts Removes reading settings from the profile and drops IUserDataProfileService injection/import.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@Giuspepe Giuspepe enabled auto-merge May 26, 2026 07:52
@Giuspepe Giuspepe added the ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch label May 26, 2026
@vs-code-engineering
Copy link
Copy Markdown
Contributor

This PR will be automatically cherry-picked to release/1.122 when merged.

@Giuspepe Giuspepe merged commit aaefe30 into main May 26, 2026
28 of 29 checks passed
@Giuspepe Giuspepe deleted the issue-reporter-settings branch May 26, 2026 08:05
@vs-code-engineering vs-code-engineering Bot added this to the 1.122.0 milestone May 26, 2026
@vs-code-engineering vs-code-engineering Bot added release-cherry-pick Automated cherry-pick between release and main branches and removed ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch labels May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-cherry-pick Automated cherry-pick between release and main branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants