Bump vendored dompurify from 3.2.7 to 3.4.5#318354
Open
jonkoops wants to merge 1 commit into
Open
Conversation
Fixes microsoft#313084 Signed-off-by: Jon Koops <jonkoops@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the vendored DOMPurify dependency to a newer upstream release and aligns repository metadata/licensing accordingly.
Changes:
- Bump DOMPurify from 3.2.7 to 3.4.5 (vendored JS + typings).
- Update third-party notices and component governance manifest to reflect the new version/commit.
- Refresh DOMPurify license/copyright attribution.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/base/browser/dompurify/dompurify.js | Update vendored DOMPurify runtime to 3.4.5 (includes upstream security/behavior changes). |
| src/vs/base/browser/dompurify/dompurify.d.ts | Update DOMPurify typings for 3.4.5, including config surface changes. |
| src/vs/base/browser/dompurify/cgmanifest.json | Bump tracked DOMPurify tag/version and commit hash. |
| src/vs/base/browser/dompurify/dompurify.license.txt | Update license header attribution details. |
| ThirdPartyNotices.txt | Update DOMPurify version listed in third-party notices. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the vendored DOMPurify copy at
src/vs/base/browser/dompurify/from 3.2.7 to 3.4.5, addressing the following CVEs:VS Code's usage (via
domSanitize.ts) does not exercise the affected code paths for most of these CVEs, as it never usesSAFE_FOR_TEMPLATES,CUSTOM_ELEMENT_HANDLING, function-formADD_TAGS/ADD_ATTR, orFORBID_TAGS.Fixes #313084