Reapply "Fix UBB model details in Copilot CLI (#316452)" (#316698)#318399
Merged
Conversation
pwang347
added
the
~release-cherry-pick
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-applies previously reverted changes that enrich Copilot CLI-provided model metadata (price category + token costs) and improves how price categories are surfaced for accessibility in the chat model picker.
Changes:
- Extend Copilot CLI model info to include
priceCategoryand normalizedinputCost/outputCost/cacheCost, and plumb these intoLanguageModelChatInformation. - Add normalization logic for Copilot CLI SDK token pricing into “AICs per 1M tokens”.
- Improve the chat model picker’s screen-reader price-category labeling by handling empty/undefined categories and providing a fallback label for unknown categories.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts | Adjusts price-category labeling used for ARIA descriptions in the model picker. |
| extensions/copilot/src/extension/chatSessions/copilotcli/node/copilotCli.ts | Adds pricing/category fields to Copilot CLI model metadata and normalizes SDK token pricing for UI consumption. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 3
Contributor
|
This PR will be automatically cherry-picked to |
Member
Author
|
CC @lramos15 on Copilot feedback. Seems valid but not urgent. |
Yoyokrazy
approved these changes
May 26, 2026
lramos15
approved these changes
May 26, 2026
This was referenced May 26, 2026
vs-code-engineering
Bot
added
release-cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit aa21abc.
Fixes #315801