Refactor browser error page to a feature contribution#318637
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the integrated browser editor’s error/certificate UI so it’s implemented as a dedicated feature contribution instead of being owned directly by BrowserEditor, while also generalizing the editor’s contribution surface for UI widgets and URL rendering.
Changes:
- Introduces a new
BrowserEditorErrorFeaturescontribution that renders the error overlay, drives the certificate indicator (“Not Secure”), and decorates URL rendering for cert errors. - Replaces the previous ad-hoc contribution hooks (
urlBarWidgets,toolbarElements,containerContents) with a unifiedwidgetsAPI keyed byBrowserWidgetLocation, plus a newurlRenderershook. - Updates existing browser editor features (zoom, find, emulation, chat, tab management, renderer overlay) to use the new widget API and locations.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/browserView/electron-browser/siteInfoWidget.ts | Deleted; site info indicator logic moved into the error feature contribution. |
| src/vs/workbench/contrib/browserView/electron-browser/features/webContentsViewRendererFeature.ts | Migrates placeholder/paused overlay contributions to widgets in the ContentArea location. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserTabManagementFeatures.ts | Migrates URL bar hint pill contribution to widgets with PostUrl location. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserEditorZoomFeature.ts | Migrates zoom pill to widgets with PostUrl location. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserEditorFindFeature.ts | Migrates find widget container insertion to widgets with Toolbar location. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserEditorErrorFeatures.ts | New contribution implementing error overlay + certificate indicator + cert-aware URL rendering. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserEditorEmulationFeatures.ts | Migrates emulation toolbar insertion to widgets with Toolbar location. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserEditorChatFeatures.ts | Migrates share button container to widgets with PostUrl location. |
| src/vs/workbench/contrib/browserView/electron-browser/browserView.contribution.ts | Registers the new error feature contribution module. |
| src/vs/workbench/contrib/browserView/electron-browser/browserEditor.ts | Introduces BrowserWidgetLocation, IBrowserEditorWidget, and IBrowserUrlRenderer; rewires editor assembly to consume widgets/urlRenderers and removes editor-owned error/cert UI. |
Copilot's findings
- Files reviewed: 10/10 changed files
- Comments generated: 1
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
vijayupadya
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.