Skip to content

Read cloud_session_storage_enabled from /copilot_internal/user instead of /v2/token#318643

Merged
vijayupadya merged 1 commit into
mainfrom
historical-prawn
May 28, 2026
Merged

Read cloud_session_storage_enabled from /copilot_internal/user instead of /v2/token#318643
vijayupadya merged 1 commit into
mainfrom
historical-prawn

Conversation

@vijayupadya
Copy link
Copy Markdown
Contributor

Moves the source of the cloud_session_storage_enabled policy flag from the Copilot /v2/token endpoint to the /copilot_internal/user (entitlements) endpoint, matching the server team's contract.

Copilot AI review requested due to automatic review settings May 27, 2026 22:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves the cloud_session_storage_enabled policy flag from the /copilot_internal/v2/token response to the /copilot_internal/user entitlements response, aligning with the server contract.

Changes:

  • Adds optional cloud_session_storage_enabled to IEntitlementsData.
  • Populates IPolicyData.cloud_session_storage_enabled from entitlements data whenever entitlements are present.
  • Removes the corresponding parsing from the token map in getTokenEntitlements.
Show a summary per file
File Description
src/vs/base/common/defaultAccount.ts Adds the new optional field to the entitlements response type.
src/vs/workbench/services/accounts/browser/defaultAccount.ts Reads cloud_session_storage_enabled from entitlements; removes token-derived value.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@vijayupadya vijayupadya marked this pull request as ready for review May 27, 2026 23:01
@vijayupadya
Copy link
Copy Markdown
Contributor Author

cc @joshspicer

@vijayupadya vijayupadya enabled auto-merge (squash) May 27, 2026 23:01
@vijayupadya vijayupadya merged commit d3b8955 into main May 28, 2026
26 checks passed
@vijayupadya vijayupadya deleted the historical-prawn branch May 28, 2026 01:04
@vs-code-engineering vs-code-engineering Bot added this to the 1.123.0 milestone May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants