Add env var to disable disposable tracking#318672
Merged
Merged
Conversation
For perf work Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an opt-out env var (VSCODE_DEV_DISABLE_DISPOSABLE_TRACKING) to skip installing the GCBasedDisposableTracker in dev builds, to reduce overhead during performance work.
Changes:
- Gate
setDisposableTracker(new GCBasedDisposableTracker())on the new env var. - Add a commented-out env entry to the "Launch VS Code Agents Internal" debug config as discoverability.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/performance/browser/performance.contribution.ts |
Imports env and adds env-var check to skip disposable tracker setup. |
.vscode/launch.json |
Adds commented example of the new env var in one launch config. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
bryanchen-d
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For perf work