feat: enhance session changeset handling with deferred refresh logic#318733
Merged
DonJayamanne merged 2 commits intoMay 28, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a deferred-refresh path for session-wide ("static") changesets that mirrors the existing uncommitted-refresh deferral: when a subscriber arrives before the session's working directory is known, the refresh is queued and drained on session materialization/restore, and dropped if the last subscriber leaves first.
Changes:
- New
_pendingSessionRefreshesset with_triggerSessionRefreshhelper, drained alongside uncommitted refreshes and cleared on disposal / last-subscriber. - Both
onFirstSubscriberSession-kind and Uncommitted fall-through paths now route through the new helper instead of callingrefreshSessionChangesetdirectly. - Added two unit tests covering deferred refresh on materialization and drop-on-unsubscribe.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/agentHost/node/agentHostChangesetCoordinator.ts | Adds deferred session-changeset refresh queue, helper, drain/cleanup; updates docstrings (one got corrupted) |
| src/vs/platform/agentHost/test/node/agentHostChangesetCoordinator.test.ts | Adds tests for defer-until-materialized and drop-on-last-subscriber behaviors |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
vijayupadya
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.