Browser: refactor navbar / welcome page to feature contributions#318765
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the Integrated Browser editor UI by moving the navigation bar and welcome/empty-state UI into BrowserEditorContributions, and consolidates browser-related actions/context into the editor/contributions rather than a standalone browserViewActions.ts.
Changes:
- Introduces
BrowserNavigationFeatures(navbar widget + navigation actions) andBrowserWelcomeFeature(welcome placeholder) as editor contributions. - Updates
BrowserEditorContributionfocus handling fromfocusPage()totryFocus()with a “first contribution wins” model, and addsprerenderInput()to render placeholder UI before the model resolves. - Removes
browserViewActions.tsand shifts action/category/group exports tobrowserEditor.ts, updating feature imports accordingly.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/browserView/electron-browser/features/webContentsViewRendererFeature.ts | Adopts new tryFocus() API and removes per-feature focus notification wiring. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserWelcomeFeature.ts | New contribution that renders/hides the welcome placeholder based on URL presence. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserTabManagementFeatures.ts | Updates imports to use action/category/group exports from browserEditor.ts. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserNavigationFeatures.ts | New contribution that owns the navbar widget, navigation context keys, and browser navigation-related actions. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserEditorZoomFeature.ts | Updates imports to use action/category/group exports from browserEditor.ts. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserEditorFindFeature.ts | Updates imports to use action/category/group exports from browserEditor.ts. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserEditorErrorFeatures.ts | Removes per-contribution browserHasError context-key binding; updates behavior to call model APIs directly. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserEditorEmulationFeatures.ts | Updates imports to use action/category/group exports from browserEditor.ts. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserEditorChatFeatures.ts | Updates imports to use action/category/group exports from browserEditor.ts. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserDevToolsFeature.ts | Updates imports and routes devtools toggle via model API. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserDataStorageFeatures.ts | Updates imports and routes storage clearing via model API. |
| src/vs/workbench/contrib/browserView/electron-browser/browserViewActions.ts | Removed; actions and related exports are relocated. |
| src/vs/workbench/contrib/browserView/electron-browser/browserView.contribution.ts | Wires new feature modules and drops browserViewActions import. |
| src/vs/workbench/contrib/browserView/electron-browser/browserEditor.ts | Moves action/category/group exports here; introduces tryFocus()/prerenderInput() contribution APIs and refactors editor focus/model wiring. |
Copilot's findings
- Files reviewed: 14/14 changed files
- Comments generated: 4
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
dmitrivMS
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.