Skip to content

[Codex] Add app-server agent host provider#318822

Merged
Giuspepe merged 17 commits into
mainfrom
gcianci/codex-app-server/agent
Jun 2, 2026
Merged

[Codex] Add app-server agent host provider#318822
Giuspepe merged 17 commits into
mainfrom
gcianci/codex-app-server/agent

Conversation

@Giuspepe
Copy link
Copy Markdown
Contributor

@Giuspepe Giuspepe commented May 28, 2026

Part 4 of 4 in the Codex app-server stack.

This PR adds the Codex agent-host provider implementation and the workbench/session wiring that consumes the protocol client:

  • Adds the Codex IAgent provider, session lifecycle, resume/replay, prompt resolution, metadata persistence, proxy/account handling, approvals, and app-server event mapping.
  • Adds session config schema support, compact config chip labels, and provider-specific routing for follow-up turns.
  • Adds focused tests for event mapping, prompt resolution, replay mapping, session config keys, chip labels, and the real Codex SDK integration test.
  • Updates existing Claude/protocol test helpers where needed for shared agent-host behavior.

This is the runtime integration layer on top of the setup, generated types, and client PRs below it.

How to test:

  • npm install to download codex-sdk as dev dependency
  • Add setting "chat.agentHost.codexAgent.path": "/path/to/node_modules/@openai/codex-sdk"
  • Select Codex - Agent Host when starting a new session in either the editor window or Agents window

@Giuspepe Giuspepe force-pushed the gcianci/codex-app-server/agent branch from 637dced to 401c9f6 Compare May 28, 2026 19:28
@Giuspepe Giuspepe force-pushed the gcianci/codex-app-server/client branch 2 times, most recently from 6fa7bd1 to cd34aa5 Compare May 28, 2026 20:29
Copilot AI review requested due to automatic review settings May 28, 2026 20:29
@Giuspepe Giuspepe force-pushed the gcianci/codex-app-server/agent branch from 401c9f6 to 013b49e Compare May 28, 2026 20:29
@Giuspepe Giuspepe force-pushed the gcianci/codex-app-server/agent branch from 013b49e to 75115b2 Compare May 28, 2026 20:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Giuspepe Giuspepe force-pushed the gcianci/codex-app-server/agent branch 4 times, most recently from 30058e4 to dccda6a Compare May 29, 2026 09:30
@Giuspepe Giuspepe force-pushed the gcianci/codex-app-server/client branch from cd34aa5 to d95eda1 Compare May 29, 2026 10:33
@Giuspepe Giuspepe force-pushed the gcianci/codex-app-server/agent branch 3 times, most recently from 594c71d to dd52411 Compare May 29, 2026 11:28
@Giuspepe Giuspepe force-pushed the gcianci/codex-app-server/client branch 2 times, most recently from 8ada85a to a130e1a Compare May 29, 2026 16:42
@Giuspepe Giuspepe force-pushed the gcianci/codex-app-server/agent branch from 353d6bc to 43442f6 Compare May 29, 2026 16:48
@Giuspepe Giuspepe marked this pull request as ready for review May 29, 2026 17:30
@Giuspepe Giuspepe force-pushed the gcianci/codex-app-server/client branch from a130e1a to 94af9c2 Compare May 29, 2026 20:20
@Giuspepe Giuspepe force-pushed the gcianci/codex-app-server/agent branch from fcff206 to bc46703 Compare May 29, 2026 20:20
@Giuspepe Giuspepe force-pushed the gcianci/codex-app-server/client branch from 94af9c2 to ea7a54a Compare June 1, 2026 09:48
@Giuspepe Giuspepe force-pushed the gcianci/codex-app-server/agent branch 2 times, most recently from 687eaf8 to 819c79a Compare June 1, 2026 10:20
@Giuspepe Giuspepe force-pushed the gcianci/codex-app-server/client branch from ea7a54a to 303a9ea Compare June 1, 2026 10:20
@Giuspepe Giuspepe marked this pull request as draft June 1, 2026 10:21
Base automatically changed from gcianci/codex-app-server/client to main June 1, 2026 12:00
Giuspepe added 8 commits June 1, 2026 14:00
New Agent Host sessions now defer config resolution and eager backend creation until authenticationPending settles. That avoids AuthRequired races for providers such as Codex, but it also means RemoteAgentHostSessionsProvider tests must explicitly settle authentication before expecting resolved config or forwarded create-session config.
@Giuspepe Giuspepe force-pushed the gcianci/codex-app-server/agent branch from 819c79a to 8943a9c Compare June 1, 2026 12:01
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

Base: 50c0f4b0 Current: ad27f8b8

No screenshot changes.

@Giuspepe Giuspepe marked this pull request as ready for review June 2, 2026 19:10
@Giuspepe Giuspepe merged commit 47f9080 into main Jun 2, 2026
25 checks passed
@Giuspepe Giuspepe deleted the gcianci/codex-app-server/agent branch June 2, 2026 23:39
@vs-code-engineering vs-code-engineering Bot added this to the 1.124.0 milestone Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants