Support quick inputs overlapping anchor elements#318858
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Quick Input anchoring API to support an explicit anchor placement mode that can “overlay” the anchor element, and updates the browser controller to position/size anchored quick inputs accordingly (including across auxiliary windows).
Changes:
- Added
anchorPosition?: 'above' | 'below' | 'overlay'toIPickOptionsandIQuickInput. - Plumbed
anchorPositionthrough quick pick creation so controllers can honor the requested placement. - Updated
QuickInputControllerto (a) reparent anchored UI into the owning window and (b) add'overlay'positioning/sizing logic.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/quickinput/common/quickInput.ts | Adds the new anchorPosition option to quick input / pick option interfaces and documents intended behavior. |
| src/vs/platform/quickinput/browser/quickInputController.ts | Wires anchorPosition, reparents anchored UI to the anchor’s window, and implements overlay/above/below positioning logic. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 5
TylerLeonhardt
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.