fix(terminal): track ligatures addon config for change detection#318992
Open
Tyriar wants to merge 1 commit into
Open
fix(terminal): track ligatures addon config for change detection#318992Tyriar wants to merge 1 commit into
Tyriar wants to merge 1 commit into
Conversation
Store ILigatureOptions in _ligaturesAddonConfig when the addon is created, clear it when the addon is disposed, and compare against the ILigatureOptions shape passed to the addon (not the full fontLigatures object, which includes enabled). Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
1db2d1e to
1b188c7
Compare
Contributor
|
@Tyriar please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Contributor
Author
|
@microsoft-github-policy-service agree company="Cursor" |
Contributor
Author
|
One day you'll remember me @microsoft-github-policy-service |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store ILigatureOptions in _ligaturesAddonConfig when the addon is created, clear it when the addon is disposed, and compare against the ILigatureOptions shape passed to the addon (not the full fontLigatures object, which includes enabled).
Fixes #318993
cc @anthonykim1