Browser: support URL suggestions#318994
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Integrated Browser URL bar to support suggestion-driven workflows by introducing a dedicated URL bar widget that uses Quick Pick as the editing surface and can aggregate suggestions/actions from browser editor contributions.
Changes:
- Add
BrowserUrlBarWidget(contenteditable display + Quick Pick overlay) with support for URL renderers, suggestion providers, and picker chrome actions. - Contribute “Open Tabs” URL-bar suggestions to enable switching/replacing the current tab from the URL picker.
- Add
onWillNavigateto the browser model to enable optimistic URL preview, plus CSS + a new electron-browser widget test suite.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/browserView/test/electron-browser/widgets/browserUrlBarWidget.test.ts | New unit tests covering URL bar rendering/editing, suggestion application, picker actions, and focus/hide behavior. |
| src/vs/workbench/contrib/browserView/electron-browser/widgets/browserUrlBarWidget.ts | New URL bar widget implementation: display rendering, picker lifecycle, provider suggestion loading, and action wiring. |
| src/vs/workbench/contrib/browserView/electron-browser/media/browser.css | Update styling for the new .browser-url-display (contenteditable + placeholder via :empty::before) and focus border behavior. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserTabManagementFeatures.ts | Add a URL suggestion provider that surfaces other open browser tabs as URL-bar suggestions. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserNavigationFeatures.ts | Replace inline URL input/display logic with BrowserUrlBarWidget, auto-open picker on empty/new tabs, and wire preview via onWillNavigate. |
| src/vs/workbench/contrib/browserView/electron-browser/browserEditor.ts | Extend contribution surface with suggestion/action provider APIs and pin/focus behavior on onWillNavigate. |
| src/vs/workbench/contrib/browserView/common/browserView.ts | Add onWillNavigate event and fire it from loadURL to support pre-navigation UI updates. |
Copilot's findings
- Files reviewed: 7/7 changed files
- Comments generated: 1
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
connor4312
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.