fix: remove awaits inside Promise.race in shell integration test#319068
Merged
anthonykim1 merged 1 commit intoMay 30, 2026
Conversation
Awaiting promises before passing them to Promise.race serializes the competitors and defeats the race. Pass the timeout and onDidChangeInput promises directly so the timeout can fire while waiting for input. Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes an async/await misuse in the shell integration addon integration test so the prompt input change wait logic actually races a timeout against an input-change event.
Changes:
- Removes premature
awaitfrom the promises passed intoPromise.race, ensuring the race behaves as intended.
anthonykim1
approved these changes
May 30, 2026
bhavyaus
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Awaiting promises before passing them to Promise.race serializes the competitors and defeats the race. Pass the timeout and onDidChangeInput promises directly so the timeout can fire while waiting for input.
@meganrogge @anthonykim1