Fix: Linkify markdown links with no space before [ when link text contains spaces#319073
Open
tamuratak wants to merge 1 commit into
Open
Fix: Linkify markdown links with no space before [ when link text contains spaces#319073tamuratak wants to merge 1 commit into
[ when link text contains spaces#319073tamuratak wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds handling in the stateful linkifier for markdown links that are immediately preceded by text without an intervening space (e.g. abc[file.ts](file.ts)), so the preceding text is emitted as its own part and the link is still detected.
Changes:
- When accumulating a
Wordand whitespace is encountered, detect an unclosed[inside the accumulated text and split the buffer into a preceding text portion plus aPotentialLinkstarting at[. - Add tests covering both single-token and incrementally-streamed inputs with markdown links preceded by text.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extensions/copilot/src/extension/linkify/common/linkifier.ts | Splits accumulated word at [ to start a PotentialLink state when the bracket is unclosed. |
| extensions/copilot/src/extension/linkify/test/node/linkifier.spec.ts | Adds tests for markdown links preceded by text, in both single and split-token scenarios. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #318866
Fix: Linkify markdown links with no space before
[when link text contains spacesWhen a markdown link is immediately preceded by text (e.g.
abc[src/main.ts 17](src/main.ts#L17)), the Linkifier's whitespace-based tokenization splits the input such that the[never lands at the start of a token, preventing the state machine from enteringPotentialLinkmode. This fix detects an unclosed[within accumulatedWordstate tokens, splits the text at the bracket, linkifies the prefix as a normal word, and transitions the remainder intoPotentialLinkstate.Created with GitHub Copilot + MiMO-V2.5-Pro
CC: @vijayupadya @justschen