agents: fix duplicate workspace created tasks firing#319078
Merged
Merged
Conversation
The autorun in WorktreeCreatedTaskDispatcher previously disposed its own store via _sessionDisposables.deleteAndDispose, which could synchronously remove the entry while the autorun was still mid-run and allow a re-entrant _trackSession call to install a fresh autorun that fires again. - Switch to reader.dispose() so the autorun tears itself down cleanly without racing _sessionDisposables bookkeeping, preventing the worktreeCreated tasks from being dispatched more than once per session. (Commit message generated by Copilot)
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes duplicate dispatch of worktreeCreated tasks by switching from _sessionDisposables.deleteAndDispose to reader.dispose() inside the registerAutorunSelfDisposable callback. The prior approach could synchronously remove the per-session disposable entry mid-autorun, allowing a re-entrant _trackSession to install a fresh autorun and fire tasks again.
Changes:
- Use
reader.dispose()to cleanly tear down the autorun without racing_sessionDisposablesbookkeeping. - Remove the now-stale comment block above the autorun.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/chat/browser/worktreeCreatedTaskDispatcher.ts | Switch self-disposal mechanism to reader.dispose(); drop obsolete comment. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
TylerLeonhardt
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agents: fix duplicate workspace created tasks firing
The autorun in WorktreeCreatedTaskDispatcher previously disposed its own store via _sessionDisposables.deleteAndDispose, which could synchronously remove the entry while the autorun was still mid-run and allow a re-entrant _trackSession call to install a fresh autorun that fires again.
(Commit message generated by Copilot)