Avoid leaving detached DOM elements in Getting Started#319128
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Getting Started editor pane to better manage disposable UI components and avoid retaining detached DOM elements.
Changes:
- Wraps the details scrollbar and Getting Started index lists in
MutableDisposable. - Updates callers to access current disposable instances via
.value. - Relies on reassignment through
MutableDisposableto dispose old UI components when rebuilding slides.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts |
Reworks lifecycle management for scrollbars and index lists to dispose replaced instances automatically. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
aiday-mar
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.