Refactor logging level from Debug to Info for state model changes#319228
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Despite the title, this PR makes two distinct kinds of changes: (1) it raises the log level of chat-input state-model change diagnostics in chatModel.ts from debug to info, and (2) it refactors the resetCurrentLanguageModelIfUnavailable closure in chatInputPart.ts, collapsing the CopilotCLI-specific branch into the general path and always emitting the diagnostic when the log level is Debug.
Changes:
- Change
_logChangesToStateModel/logChangesToStateModelto gate on and emit atLogLevel.Infoinstead ofLogLevel.Debug(includes stack traces). - Unify the
SessionType.CopilotCLIand non-CLI branches inresetCurrentLanguageModelIfUnavailable, dropping the!models.some(m => m.metadata.id === modelIdentifier)extra guard previously applied only to CopilotCLI. - Expand the debug diagnostic payload (adds
currentModeKind,shouldResetOnModelListChange,vendors,hiddenModelIds).
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/common/model/chatModel.ts |
Promotes the chat input state-model change logging from debug to info in both helper functions. |
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts |
Refactors the model-reset closure: removes the CopilotCLI-specific reset guard, always emits the diagnostic at Debug level, and extends the diagnostic payload. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 3
bhavyaus
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.