Continue // line comment on Enter in SCSS#319325
Open
yogeshwaran-c wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the SCSS language configuration to auto-continue // line comments when pressing Enter.
Changes:
- Adds a new
onEnterRulesentry intended to append//on the next line when inside a line comment.
Comment on lines
+52
to
57
| "action": { | ||
| "indent": "none", | ||
| "appendText": "// " | ||
| } | ||
| }, | ||
| ] |
| } | ||
| } | ||
| }, | ||
| // Add // when pressing enter from inside line comment |
Comment on lines
+46
to
+55
| "beforeText": { | ||
| "pattern": "\/\/.*" | ||
| }, | ||
| "afterText": { | ||
| "pattern": "^(?!\\s*$).+" | ||
| }, | ||
| "action": { | ||
| "indent": "none", | ||
| "appendText": "// " | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@
Pressing Enter from within a
//line comment in an SCSS file does not continue the comment, even though SCSS uses//as its line comment ("lineComment": "//").This behavior was added for languages using
//line comments in #235407 (which fixed #118929), coveringcpp,csharp,go,groovy,java,json,less,objective-c,php,rustandswift— but SCSS was missed.This PR adds the same
onEnterRuletoextensions/scss/language-configuration.json, matching the form already used in the sibling LESS configuration, so SCSS gets parity. The existing///doc-comment rule is kept and placed first so the more specific rule still wins.Refs #118929
@