Make sure reopen as text is enabled in modal change views too#319462
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the editor title menu registration so that “Reopen as Text” is also available when viewing custom text diffs in modal editor change views (i.e., menu MenuId.ModalEditorEditorTitle), aligning it with other diff title actions that already opt into modal mode.
Changes:
- Enable the “Reopen as Text” editor title action for modal editor title menus by setting
enableInModalModetotrueinappendEditorToolItem.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/browser/parts/editor/editor.contribution.ts |
Registers “Reopen as Text” for the modal editor title menu via appendEditorToolItem(..., enableInModalMode: true). |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
rzhao271
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.