Skip to content

[cherry-pick] [cherry-pick] [release/1.123] Allow sandbox writes to workspace storage#319495

Merged
dileepyavan merged 1 commit into
release/1.123from
cherry-pick/319486
Jun 2, 2026
Merged

[cherry-pick] [cherry-pick] [release/1.123] Allow sandbox writes to workspace storage#319495
dileepyavan merged 1 commit into
release/1.123from
cherry-pick/319486

Conversation

@vs-code-engineering
Copy link
Copy Markdown
Contributor

Cherry-pick of #319486 from main.

Summary

  • allow terminal sandbox writes to the workspace storage folder
  • preserve the refactored shared TerminalSandboxEngine architecture
  • document the workspace storage write root across Linux, macOS, and Windows settings

Validation

  • terminalSandboxService.test.ts: 62 passed, 0 failed

Copilot AI review requested due to automatic review settings June 2, 2026 01:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@vs-code-engineering vs-code-engineering Bot added the cherry-pick-artifact Auto-generated cherry-pick PR label Jun 2, 2026
@vs-code-engineering
Copy link
Copy Markdown
Contributor Author

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@anthonykim1

Matched files:

  • src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalChatAgentToolsConfiguration.ts
  • src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/terminalSandboxService.test.ts

@deepak1556
Copy link
Copy Markdown
Collaborator

Title needs correction, why release/1.121 ?

@dileepyavan dileepyavan changed the title [cherry-pick] [cherry-pick] [release/1.121] Allow sandbox writes to workspace storage [cherry-pick] [cherry-pick] [release/1.123] Allow sandbox writes to workspace storage Jun 2, 2026
@dileepyavan dileepyavan enabled auto-merge (squash) June 2, 2026 01:43
@dileepyavan dileepyavan merged commit 8743128 into release/1.123 Jun 2, 2026
25 checks passed
@dileepyavan dileepyavan deleted the cherry-pick/319486 branch June 2, 2026 02:38
@vs-code-engineering vs-code-engineering Bot added this to the 1.123.0 milestone Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-artifact Auto-generated cherry-pick PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants